test: migrate markdown editor to component tests [TOL-1355] #1553
Conversation
|
Marking pull request as stale since there was no activity for 30 days |
…t/migrate-markdown-editor
| it('should have correct title', () => { | ||
| renderMarkdownEditor(); |
There was a problem hiding this comment.
Maybe move this render to beforeEach?
There was a problem hiding this comment.
We could for some contexts, but it has some props so that means more code to change if we later want to add props for some reason
| it('should have correct title', () => { | ||
| renderMarkdownEditor(); |
There was a problem hiding this comment.
Same here. Can we use beforeEach?
| }; | ||
|
|
||
| export const clearAll = (): void => { | ||
| //Using extra select all because of flakiness with a single clear |
There was a problem hiding this comment.
What do you mean?
There was a problem hiding this comment.
Comment looks like excessive?
There was a problem hiding this comment.
Maybe, I didn't want to assume it would be obvious since clear() also does .type('{selectall}'), but we could remove it
There was a problem hiding this comment.
Ah, then makes sense! Maybe mention it there then for those who didn't know that (me)?
No description provided.