Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: location null lat/lon issue [] #1537

Merged
merged 3 commits into from
Nov 7, 2023
Merged

fix: location null lat/lon issue [] #1537

merged 3 commits into from
Nov 7, 2023

Conversation

aodhagan-cf
Copy link
Contributor

@aodhagan-cf aodhagan-cf commented Nov 7, 2023 •
edited
Loading

Before (when lat and lon are both null):
Screenshot 2023-11-07 at 12 15 55

After (when lat and lon are both null):
Screenshot 2023-11-07 at 12 15 26

  • If either lat or lon is set but not the other than setting the other to 0
  • If both lat or lon are not set then setting localValue to undefined to remove disabled state
  • If both lat and lon are set then should show both

@aodhagan-cf aodhagan-cf requested a review from a team as a code owner November 7, 2023 12:16
2wce
2wce approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@2wce 2wce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/location/src/LocationEditor.tsx Outdated
selectedView={selectedView}
setSelectedView={setSelectedView}
/>
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we are now returning a fragment instead of just the location editor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha damn, was testing stuff and it was left over. I've removed thanks for spotting!

chrishelgert
chrishelgert reviewed Nov 7, 2023
View reviewed changes
packages/location/src/LocationEditor.tsx Outdated
selectedView={selectedView}
setSelectedView={setSelectedView}
/>
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need a fragment here? :o

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have removed, sorry it was left over from testing stuff

@aodhagan-cf aodhagan-cf enabled auto-merge (squash) November 7, 2023 12:27
@aodhagan-cf aodhagan-cf merged commit 36fcbc4 into master Nov 7, 2023
8 checks passed
@aodhagan-cf aodhagan-cf deleted the fix/location_editor_null_issue branch November 7, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2wce 2wce 2wce approved these changes

@chrishelgert chrishelgert chrishelgert approved these changes

Assignees
No one assigned
Labels
package:location
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aodhagan-cf @chrishelgert @2wce