Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: turn into dual node package with additional browser bundle #2169

Merged
merged 84 commits into from
Sep 19, 2024
Merged

refactor: turn into dual node package with additional browser bundle #2169

merged 84 commits into from
Sep 19, 2024

Conversation

axe312ger
Copy link
Collaborator

@axe312ger axe312ger commented Feb 22, 2024 •
edited
Loading

Requires contentful/contentful-sdk-core#438

  • remove node (minified) bundle
  • make available in cjs (as bundle for node without ESM support)
  • make available in esm
  • support ESM only dependencies
  • support browser plain + minified
  • switch from jest to vitest
  • switch to rollup from webpack

Will fix:

@axe312ger axe312ger requested a review from a team as a code owner February 22, 2024 17:36
@mgoudy91 mgoudy91 force-pushed the refactor/modern-esm-support branch from bfcdc04 to e724aa5 Compare February 22, 2024 20:39
@mgoudy91 mgoudy91 force-pushed the refactor/modern-esm-support branch from e724aa5 to b2f5be5 Compare February 27, 2024 17:25
dependabot bot and others added 24 commits March 20, 2024 17:59
@dependabot @axe312ger
build(deps-dev): bump express from 4.18.2 to 4.18.3 (#2174)
a2c58c9 
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.18.3.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.18.3)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ghepting @axe312ger
chore: unown package files [] (#2165)
4b8a5f7
@dependabot @axe312ger
build(deps-dev): bump typedoc from 0.25.9 to 0.25.10 (#2176)
d7bb894 
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.25.9 to 0.25.10.
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](TypeStrong/typedoc@v0.25.9...v0.25.10)

---
updated-dependencies:
- dependency-name: typedoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @axe312ger
build(deps): bump type-fest from 4.10.3 to 4.11.0 (#2177)
7304583 
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.10.3 to 4.11.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.10.3...v4.11.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @axe312ger
build(deps): bump @contentful/rich-text-types from 16.3.4 to 16.3.5 (#…
5ba3ef6 
…2178)

Bumps [@contentful/rich-text-types](https://github.com/contentful/rich-text) from 16.3.4 to 16.3.5.
- [Release notes](https://github.com/contentful/rich-text/releases)
- [Changelog](https://github.com/contentful/rich-text/blob/master/CHANGELOG.md)
- [Commits](https://github.com/contentful/rich-text/compare/@contentful/rich-text-types@16.3.4...@contentful/rich-text-types@16.3.5)

---
updated-dependencies:
- dependency-name: "@contentful/rich-text-types"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @axe312ger
build(deps): bump type-fest from 4.11.0 to 4.11.1 (#2179)
414e63d 
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.11.0 to 4.11.1.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.11.0...v4.11.1)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@david-shibley-contentful @axe312ger
feat: github migration [EXT-5014]
289bac7
@david-shibley-contentful @axe312ger
feat: github migration [EXT-5014]
4c7fefc
@david-shibley-contentful @axe312ger
adding vault context
5946e13
@ContentfulCormac @axe312ger
fix: [] - fix build
5a9827f
@dependabot @axe312ger
build(deps-dev): bump typedoc from 0.25.10 to 0.25.11 (#2182)
f2073d5 
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.25.10 to 0.25.11.
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](TypeStrong/typedoc@v0.25.10...v0.25.11)

---
updated-dependencies:
- dependency-name: typedoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @axe312ger
build(deps-dev): bump typedoc from 0.25.11 to 0.25.12 (#2183)
e0288ee 
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.25.11 to 0.25.12.
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](TypeStrong/typedoc@v0.25.11...v0.25.12)

---
updated-dependencies:
- dependency-name: typedoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @axe312ger
build(deps): bump type-fest from 4.11.1 to 4.12.0 (#2184)
2ebc1df 
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.11.1 to 4.12.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.11.1...v4.12.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@axe312ger
wip: use rollup to bundle
0110e51
@axe312ger
refactor: improve rollup integration
f8d0670
@axe312ger
WIP - replace Jest with Vitest
2a7748d
@axe312ger
refactor: fix all integration tests and clean up
bf44d13
@axe312ger
build: fix rollup browser bundle
551ae23
@axe312ger
Merge branch 'master' into refactor/modern-esm-support
e938f5c
@axe312ger
build: fix rollup process resolve
53f3411
@axe312ger
build: readd tsd
2c070c8
@axe312ger
build: remove bundle size check again from postbuild to avoid issues …
97fa9ff 
…on CI
@axe312ger
ci: move to latest node v18 to avoid warnings while installing
2ca610e
@axe312ger
build: adjust for new structure of contentful-sdk-core
e680dd5
@paulcrussell paulcrussell mentioned this pull request Sep 3, 2024
Closed
mgoudy91
mgoudy91 previously approved these changes Sep 9, 2024
View reviewed changes
mgoudy91 and others added 10 commits September 10, 2024 08:53
@mgoudy91
test: test updates
81411c8
@mgoudy91
BREAKING CHANGE: adding dry run flag, BC commit tag to force major (#…
829200d 
…2325)

BREAKING CHANGE: adding dry run flag, BC commit tag to force major (#2325)
@dependabot
build(deps-dev): bump express in the dev-dependencies group (#2326)
c133084 
Bumps the dev-dependencies group with 1 update: [express](https://github.com/expressjs/express).


Updates `express` from 4.19.2 to 4.20.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.19.2...4.20.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@axe312ger
Merge branch 'master' into refactor/modern-esm-support
201c5ab
@dependabot
build(deps-dev): bump express in the dev-dependencies group (#2327)
3afc352 
Bumps the dev-dependencies group with 1 update: [express](https://github.com/expressjs/express).


Updates `express` from 4.20.0 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.20.0...4.21.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mgoudy91
Merge branch 'master' into refactor/modern-esm-support
7db6ac6
@dependabot
build(deps): bump the production-dependencies group with 2 updates (#…
52f5dfc 
…2328)

Bumps the production-dependencies group with 2 updates: [@contentful/content-source-maps](https://github.com/contentful/live-preview) and [contentful-sdk-core](https://github.com/contentful/contentful-sdk-core).


Updates `@contentful/content-source-maps` from 0.11.2 to 0.11.3
- [Release notes](https://github.com/contentful/live-preview/releases)
- [Commits](https://github.com/contentful/live-preview/compare/@contentful/content-source-maps@0.11.2...@contentful/content-source-maps@0.11.3)

Updates `contentful-sdk-core` from 8.3.1 to 8.3.2
- [Release notes](https://github.com/contentful/contentful-sdk-core/releases)
- [Commits](contentful/contentful-sdk-core@v8.3.1...v8.3.2)

---
updated-dependencies:
- dependency-name: "@contentful/content-source-maps"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: contentful-sdk-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump babel-loader in the dev-dependencies group (#2329)
e03c62a 
Bumps the dev-dependencies group with 1 update: [babel-loader](https://github.com/babel/babel-loader).


Updates `babel-loader` from 9.1.3 to 9.2.1
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v9.1.3...v9.2.1)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mgoudy91
Merge remote-tracking branch 'origin' into refactor/modern-esm-support
3690d2a
@dependabot
build(deps-dev): bump nodemon in the dev-dependencies group (#2330)
7f7ca93 
Bumps the dev-dependencies group with 1 update: [nodemon](https://github.com/remy/nodemon).


Updates `nodemon` from 3.1.4 to 3.1.5
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](remy/nodemon@v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: nodemon
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 2 commits September 19, 2024 08:26
@dependabot @mgoudy91
build(deps-dev): bump nodemon in the dev-dependencies group (#2330)
a813188 
Bumps the dev-dependencies group with 1 update: [nodemon](https://github.com/remy/nodemon).

Updates `nodemon` from 3.1.4 to 3.1.5
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](remy/nodemon@v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: nodemon
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mgoudy91
chore: rm dry-run flag
5d5415a
@mgoudy91 mgoudy91 merged commit 72864fb into master Sep 19, 2024
3 checks passed
@mgoudy91 mgoudy91 deleted the refactor/modern-esm-support branch September 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoudy91 mgoudy91 mgoudy91 left review comments

@jjolton-contentful jjolton-contentful jjolton-contentful left review comments

Assignees
No one assigned
Labels
awaiting feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@axe312ger @mgoudy91 @jjolton-contentful @ghepting @david-shibley-contentful @ContentfulCormac