Remove the redundant regex check.

contao · Jan 19, 2018 · 3b692c4 · 3b692c4
1 parent 57803a5
commit 3b692c4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/system/modules/core/library/Contao/Database/Mysql.php b/system/modules/core/library/Contao/Database/Mysql.php
@@ -95,10 +95,7 @@ protected function get_error()
 	 */
 	protected function find_in_set($strKey, $varSet, $blnIsField=false)
 	{
-		if (preg_match('/^[A-Za-z0-9_$]+$/', $strKey))
-		{
-			$strKey = static::quoteIdentifier($strKey);
-		}
+		$strKey = static::quoteIdentifier($strKey);
 
 		if ($blnIsField)
 		{

diff --git a/system/modules/core/library/Contao/Database/Mysqli.php b/system/modules/core/library/Contao/Database/Mysqli.php
@@ -85,10 +85,7 @@ protected function get_error()
 	 */
 	protected function find_in_set($strKey, $varSet, $blnIsField=false)
 	{
-		if (preg_match('/^[A-Za-z0-9_$]+$/', $strKey))
-		{
-			$strKey = static::quoteIdentifier($strKey);
-		}
+		$strKey = static::quoteIdentifier($strKey);
 
 		if ($blnIsField)
 		{