cmd/run: Unset detach keys when executing commands #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b078d7d to
d47bcef
Compare
|
Build failed.
|
debarshiray
reviewed
Sep 2, 2020
Podman sets 'ctrl-p ctrl-q' as the default key sequence for detaching a container. This breaks the ctrl-p shortcut that's equivalent to the up arrow key in GNU Readline environments like Bash and Emacs. Moreoever, toolbox containers aren't meant to be detached in the first place. Since Podman 1.8.1, it is now possible to unset the key sequence for detaching [2, 3]. [0] https://tiswww.cwru.edu/php/chet/readline/readline.html#SEC15 [1] https://www.gnu.org/software/emacs/tour/ [2] Podman commit 7c623bd41ff3d534 containers/podman#4208 [3] Podman commit ebfd253fc658ffc9 containers/podman#5166 containers#394
d47bcef to
0c08a42
Compare
|
Build failed.
|
|
Thanks for working on this, @EnigmaCurry ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman sets keys 'ctrl-p' and 'ctrl-q' as the default detach keys. This behaviour is not desirable in Toolbox. Since Podman v1.8.2[0] it is possible to have set no detach keys by passing an empty string to the --detach-keys option.
Thanks to this the 'Ctrl+p' and 'Ctrl-q' combinations are doing what they should do normally in a terminal.
Fixes: #394
This PR is a reincarnation of #396 that I mistakenly closed by badly updating the author's branch.