-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rm and rmi commands #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch needs to be rebased on top of master
. Some quick comments:
I've added the possibility to remove multiple images/containers at once. Toolbox rm and rmi commands can now take more than one name/ID, the same way podman rm and rmi commands do it. |
I think long names like 'delete' and 'delete-image' would go better with the existing create/list/enter |
I have been going back and forth on that myself. We can definitely add the longer names as aliases. eg., At the same time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some feedback after using this branch for a few days:
It mostly looks good. We now have man
pages, so we need to add those for these new commands, and we need to make the commands work inside a toolbox container.
Rest of the details below:
I took the liberty to address the above nits. |
Add rm and rmi commands for images/containers removal. Both commands take ID or name as an argument and if the specified image/container was created by fedora-toolbox, it's removed.
Both commands have two flags: --all and --force. With the --all flag, the argument is not needed, as the command tries to remove all fedora-toolbox images/containers. The --force flag just runs force removal (i.e podman rm/rmi --force )