Inherit COLUMNS and LINES at host #243
Conversation
e854fad to
2d7532a
Compare
|
LGTM and fixes the issue for me too (which seemed to start with podman-1.5?) |
2d7532a to
295181d
Compare
|
I took the liberty to make the above tweaks, but I don't have enough time to convince myself that I didn't break anything. :) Does it look ok to you? |
f872ce5 to
2c8970d
Compare
|
Updated. |
See: containers/podman#3946 COLUMNS and LINES may not be set in the user's environment. Hence the existing mechanism for preserving environment variables don't work. Note that for things to keep working when invoked via D-Bus from inside a toolbox container, the terminal size needs to be queried using the standard input stream, instead of explicitly mentioning the controlling terminal device /dev/tty. This is because stty(1) doesn't have the notion of a controlling terminal when invoked via D-Bus, but flatpak-spawn(1) ensures that the standard input stream still points to the user's interactive terminal. https://github.com/debarshiray/toolbox/issues/242
|
I wonder if there's some race involved here. For some reason this bug stopped reproducing today out of the blue, even with the same software versions that were reliably reproducing it until last Thursday. |
2c8970d to
05544fb
Compare
|
I made the above tweaks and pushed to master! Thanks for your contribution. :) |
| lines="" | ||
| fi | ||
|
|
||
| environment_options="$environment_options --env=COLUMNS=$columns --env=LINES=$lines" |
There was a problem hiding this comment.
Eek! This was a copy paste fiasco on my part. Embarassing. :(
| columns="" | ||
| lines="" | ||
|
|
||
| if terminal_size=$(stty size 2>&3); then |
There was a problem hiding this comment.
I missed that just stty(1) isn't enough when toolbox(1) is invoked from inside a container. In that case stty(1) will get run against the inner pseudo-terminal pair created by podman exec --tty which doesn't have the right sizes. I think we should forward the COLUMNS and LINES variables from the outer environment created by toolbox(1).
|
I created https://github.com/debarshiray/toolbox/pull/255 for these issues as a follow-up. One part of me really wishes that containers/podman#3946 gets fixed as soon as possible and we can revert this workaround. :) |
to keep same terminal window size on host.
Both COLUMNS and LINES isn't actually environment variables.
So the existing create_environment_options() can't be used for this purpose.
This fixes https://github.com/debarshiray/toolbox/issues/242