Update golangci-lint #2063
Merged
Update golangci-lint #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
reviewed
Aug 15, 2024
There was a problem hiding this comment.
LGTM.
Eventually we should automate this via https://github.com/containers/automation/blob/4739c8921cc52a1c046c2d5248d88e6f8b8755de/renovate/defaults.json5#L101 , but that’s not quite as urgent as fixing broken CI.
56b5856 to
32bbf42
Compare
saschagrunert
approved these changes
Aug 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhatdan
reviewed
Aug 16, 2024
tests/tools/Makefile
Outdated
| $(BUILDDIR)/golangci-lint: | ||
| curl -fsSL https://raw.githubusercontent.com/golangci/golangci-lint/$(VERSION)/install.sh | sh -s -- -b ./$(BUILDDIR) $(VERSION) | ||
| $(BUILDDIR)/golangci-lint: |
There was a problem hiding this comment.
Does it make sense to have this line twice?
Signed-off-by: Jan Rodák <hony.com@seznam.cz>
drivers/driver.go:499:18: printf: non-constant format string in call to github.com/sirupsen/logrus.Errorf (govet) drivers/overlay/overlay.go:1495:44: printf: non-constant format string in call to (*github.com/sirupsen/logrus.Logger).Logf (govet) Signed-off-by: Jan Rodák <hony.com@seznam.cz>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
golangci-lintand fixes new warnings.