Fix build failures #1954
Merged
Fix build failures #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
It's only called from Linux-only code (so we don't want to include it in non-Linux builds of pkg/chunked); and at least the tests currently require Linux-only files. The bloom filter code could probably be moved into an architecture-independent subpackage easily enough, this commit is taking the lazy way. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Avoid a duplicate definition of GetKernelVersion. Move CheckKernelVersion to still be available on all Unixes. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... even those not used by the command. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… so that
golangci-lint run ./...on macOS at least compiles everything.See individual commit messages for details.