dump: handle duplicates

[giuseppe]

Add validation for duplicate entries. Duplicates are ignored, unless there is a mismatch in the values. In that case, an error is returned.

Also refactor the tests to avoid duplication.

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cgwalters]

This makes sense to me, but can you explain briefly what motivated the change just for reference? Did you come across an image in the wild with duplicates? Were you just thinking through the problem domain? Is this split out of a different larger pending work PR?

[rhatdan]

LGTM

[giuseppe]

This makes sense to me, but can you explain briefly what motivated the change just for reference? Did you come across an image in the wild with duplicates? Were you just thinking through the problem domain? Is this split out of a different larger pending work PR?

no, I've not encountered yet such case. I was just looking at ways to make the dump code more robust, since most of the issues we had with composefs were caused by the conversion to the dump format

[rhatdan]

/lgtm