Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay: remove unreachable code #1934

Merged

Conversation

giuseppe
Copy link
Member

the removed code is not reachable since permsKnown must be true to be in this code branch.

Closes: #1900

Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented May 30, 2024

LGTM

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mtrmac
Copy link
Collaborator

mtrmac commented May 30, 2024

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm label May 30, 2024
the removed code is not reachable since permsKnown must be true to be
in this code branch.

Closes: containers#1900

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the remove-unreachable-code branch from bba6536 to 0c883a5 Compare May 30, 2024 21:28
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 31, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7ad4028 into containers:main May 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreachable code in storage/drivers/overlay/overlay.go
4 participants