Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-healthcheck command to create/run #5300

Merged
merged 1 commit into from
Feb 23, 2020

Conversation

baude
Copy link
Member

@baude baude commented Feb 22, 2020

Now support --no-healthcheck option to disable defined healthchecks in a container image. --health-cmd=none remains supported as well.

Fixes: #5299

Signed-off-by: Brent Baude bbaude@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M labels Feb 22, 2020
Now support --no-healthcheck option to disable defined healthchecks in a container image.  --health-cmd=none remains supported as well.

Fixes: containers#5299

Signed-off-by: Brent Baude <bbaude@redhat.com>
@mheon
Copy link
Member

mheon commented Feb 22, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Feb 23, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 23, 2020
@baude
Copy link
Member Author

baude commented Feb 23, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit eef9875 into containers:master Feb 23, 2020
@baude baude deleted the disablehealth branch May 7, 2020 13:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to disable healthcheck(s)
5 participants