Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ubuntu doc adjustment #5025

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Feature/ubuntu doc adjustment #5025

merged 2 commits into from
Jan 30, 2020

Conversation

delight
Copy link

@delight delight commented Jan 30, 2020

Adjusts install.md (Ubuntu):

  • registries.conf setup is now in containers-image package
  • replaces ${NAME} with hard-encoded Ubuntu to support all *buntu flavors
  • combines downloading and registering of the apt-secure key into a piped oneliner

…u to support all *buntu flavors

	- combines downloading and registering of the apt-secure key into a piped oneliner
@openshift-ci-robot
Copy link
Collaborator

Hi @delight. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS labels Jan 30, 2020
@vrothberg
Copy link
Member

@lsm5 PTAL

@rhatdan
Copy link
Member

rhatdan commented Jan 30, 2020

LGTM

@baude
Copy link
Member

baude commented Jan 30, 2020

/approve

@baude
Copy link
Member

baude commented Jan 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@mheon
Copy link
Member

mheon commented Jan 30, 2020

/ok-to-test
/approve
LGTM

@openshift-ci-robot openshift-ci-robot added ok-to-test approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2020
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the apt-key-add simplification can be used for other debian / raspbian sections too for consistency, but either way works..

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, delight, lsm5, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ee0b328 into containers:master Jan 30, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants