Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: mirror information #4681

Merged
merged 4 commits into from
Dec 17, 2019
Merged

podman: mirror information #4681

merged 4 commits into from
Dec 17, 2019

Conversation

jvanz
Copy link
Contributor

@jvanz jvanz commented Dec 12, 2019

Updates the podman info command to show the mirror information

Issue #4553

Signed-off-by: José Guilherme Vanz jvanz@jvanz.com

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2019
@openshift-ci-robot
Copy link
Collaborator

Hi @jvanz. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Dec 12, 2019

Doesn't podman info man page need to be updated?

@rhatdan
Copy link
Member

rhatdan commented Dec 12, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 12, 2019
@giuseppe
Copy link
Member

LGTM

@vrothberg
Copy link
Member

Doesn't podman info man page need to be updated?

Yes, the example is referencing the old format.

@jvanz
Copy link
Contributor Author

jvanz commented Dec 12, 2019

Doesn't podman info man page need to be updated?

Fixed

vrothberg
vrothberg reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomSweeneyRedHat
TomSweeneyRedHat reviewed Dec 12, 2019
View reviewed changes
install.md Outdated Show resolved Hide resolved
jvanz added 2 commits December 12, 2019 19:53
@jvanz
podman: mirror information
4f9672e 
Updates the podman info command to show the mirror information

Issue containers#4553

Signed-off-by: José Guilherme Vanz <jvanz@jvanz.com>
@jvanz
podman info man: example update
1b99651 
Updates the command output example to show information about registries
and their mirrors

Signed-off-by: José Guilherme Vanz <jvanz@jvanz.com>
@jvanz
runtime.go: show search table in podman info
95d26e3 
Updates the podman info command to show registries from v1 config file
in the search table format.

Signed-off-by: José Guilherme Vanz <jvanz@jvanz.com>
@jvanz
runtime.go: show registries data and search table
40f4a00 
Update podman info command to show the registries data and the search
table.

Signed-off-by: José Guilherme Vanz <jvanz@jvanz.com>
@jvanz jvanz requested a review from vrothberg December 13, 2019 14:12
@rhatdan
Copy link
Member

rhatdan commented Dec 13, 2019

LGTM
Waiting for @vrothberg to give final LGTM

vrothberg
vrothberg reviewed Dec 13, 2019
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the nice contribution @jvanz !

@rhatdan
Copy link
Member

rhatdan commented Dec 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2019
@jvanz
Copy link
Contributor Author

jvanz commented Dec 17, 2019

/assign @baude

@jvanz
Copy link
Contributor Author

jvanz commented Dec 17, 2019 •
edited
Loading

I've assigned @baude because the bot said that is necessary to complete the pull request. But maybe @vrothberg is more aware of the change.

@jvanz
Copy link
Contributor Author

jvanz commented Dec 17, 2019

/assign @vrothberg

@jvanz jvanz requested a review from vrothberg December 17, 2019 11:22
@rhatdan
Copy link
Member

rhatdan commented Dec 17, 2019

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Dec 17, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jvanz, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1e440a3 into containers:master Dec 17, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@rhatdan rhatdan

@baude baude

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jvanz @openshift-ci-robot @rhatdan @giuseppe @vrothberg @TomSweeneyRedHat @baude @openshift-merge-robot