Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in containers/storage v1.12.16 #3675

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 30, 2019

This will allow podman to run with a single rootless UID Map and ignore
chown errors. Potential use case for HPC Customers.

Other optimizations and bugfixes in containers/storage.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 30, 2019
@mheon
Copy link
Member

mheon commented Jul 30, 2019

LGTM once tests go green

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But tests aren't hip

@vrothberg
Copy link
Member

I can reproduce locally and will take a look

[+0400s] TYPE            TOTAL   ACTIVE   SIZE    RECLAIMABLE
[+0400s] Images          8       2        111MB   109MB (98%)
[+0400s] Containers      2       0        0B      0B (0%)
[+0400s] Local Volumes   1       1        0B      0B (0%)
...
[+0400s]   Expected
[+0400s]       <string>: 8
[+0400s]   to equal
[+0400s]       <string>: 9
[+0400s] 
[+0400s]   /var/tmp/go/src/github.com/containers/libpod/test/e2e/system_df_test.go:59

@vrothberg
Copy link
Member

/var/tmp/go/src/github.com/containers/libpod/test/e2e/system_df_test.go:59 is also failing on master. I'll try to fix it there so you can rebase here.

@vrothberg
Copy link
Member

/retest

@vrothberg
Copy link
Member

/test all

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3573) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit ee15e76 into containers:master Aug 1, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants