Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch up input argument error on create #3668

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Touch up input argument error on create #3668

merged 1 commit into from
Jul 30, 2019

Conversation

TomSweeneyRedHat
Copy link
Member

Add an error when there are not enough input arguments for remote
create. Addresses comments in #3656

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Jul 29, 2019
@rhatdan
Copy link
Member

rhatdan commented Jul 30, 2019

This LGTM but tests are not happy.

@TomSweeneyRedHat
Touch up input argument error on create
0b14e53 
Add an error when there are not enough input arguments for remote
create.  Addresses comments in #3656

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@TomSweeneyRedHat
Copy link
Member Author

Thanks @RedHatDan, gofmt will be the death of me yet. Repushed.

@mheon
Copy link
Member

mheon commented Jul 30, 2019

Code LGTM, and tests look green. Let's get this landed.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4196a59 into containers:master Jul 30, 2019
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/adderror branch July 30, 2019 17:24
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe Awaiting requested review from giuseppe

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomSweeneyRedHat @openshift-ci-robot @rhatdan @mheon @openshift-merge-robot