When refreshing after a reboot, force lock allocation #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got some lint unhappiness @mheon |
After a reboot, when we refresh Podman's state, we retrieved the lock from the fresh SHM instance, but we did not mark it as allocated to prevent it being handed out to other containers and pods. Provide a method for marking locks as in-use, and use it when we refresh Podman state after a reboot. Fixes containers#2900 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
|
Refresh tests are failing, which I suppose is expected given that the old locks still exist... We already deprecated |
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
jwhonce
approved these changes
May 6, 2019
| // Returns an error if the semaphore with this ID does not exist, or has already | ||
| // been allocated. | ||
| // Returns 0 on success, or negative errno values on failure. | ||
| int32_t allocate_given_semaphore(shm_struct_t *shm, uint32_t sem_index) { |
There was a problem hiding this comment.
errno's are more correctly defined as int by the standard.
|
|
||
| return 0; | ||
| } | ||
|
|
||
| // Deallocate a given semaphore | ||
| // Returns 0 on success, negative ERRNO values on failure | ||
| int32_t deallocate_semaphore(shm_struct_t *shm, uint32_t sem_index) { |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a reboot, when we refresh Podman's state, we retrieved the lock from the fresh SHM instance, but we did not mark it as allocated to prevent it being handed out to other containers and pods.
Provide a method for marking locks as in-use, and use it when we refresh Podman state after a reboot.
Fixes #2900