Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix rootless tests #2704

Merged
merged 9 commits into from
Mar 19, 2019
Merged

tests: fix rootless tests #2704

merged 9 commits into from
Mar 19, 2019

Conversation

giuseppe
Copy link
Member

based on #2695

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL labels Mar 19, 2019
@rh-atomic-bot
Copy link
Collaborator

💥 Invalid .papr.yml: failed to parse 1st testsuite: at least one of 'host', 'container', or 'cluster' required.

1 similar comment
@rh-atomic-bot
Copy link
Collaborator

💥 Invalid .papr.yml: failed to parse 1st testsuite: at least one of 'host', 'container', or 'cluster' required.

@giuseppe giuseppe force-pushed the fix-some-rootless branch from 3c589c4 to 14655f7 Compare March 19, 2019 09:49
@rh-atomic-bot
Copy link
Collaborator

💥 Invalid .papr.yml: failed to parse 1st testsuite: at least one of 'host', 'container', or 'cluster' required.

@giuseppe giuseppe force-pushed the fix-some-rootless branch 6 times, most recently from 3ca8304 to d9baf1c Compare March 19, 2019 13:35
@baude baude mentioned this pull request Mar 19, 2019
Closed
baude and others added 9 commits March 19, 2019 15:01
@baude @giuseppe
Enable rootless integration tests
c6b205b 
Signed-off-by: baude <bbaude@redhat.com>
@giuseppe
rootless: fix pod kill
6959392 
we don't need to access the storage

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
rootless: fix ps command
3f96d36 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
rootless, rm: fix retcode when the container is not found
4ab7462 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
test: fix SkipIfRootless() helper
66d2190 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
rootless: reimplement restart with rootless.Argument()
ffc0886 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
rootless: implement pod restart
ab576e8 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
tests: re-enable some tests for rootless mode
b581fa1 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
ps: fix segfault if the store is not initialized
4ac08d3 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the fix-some-rootless branch from d9baf1c to 4ac08d3 Compare March 19, 2019 14:02
@giuseppe
Copy link
Member Author

giuseppe commented Mar 19, 2019 •
edited
Loading

rootless tests are passing!

/cc @baude @rhatdan

let's merge this :-)

@giuseppe giuseppe changed the title [WIP] tests: fix rootless tests tests: fix rootless tests Mar 19, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2019
@rhatdan
Copy link
Member

rhatdan commented Mar 19, 2019

LGTM

@baude
Copy link
Member

baude commented Mar 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2019
@cevich
Copy link
Member

cevich commented Mar 19, 2019

SUCCESS! -- 463 Passed | 0 Failed | 3 Flaked | 0 Pending | 159 Skipped

Wow that's really nice to see!

@openshift-merge-robot openshift-merge-robot merged commit a1299f5 into containers:master Mar 19, 2019
This was referenced Mar 19, 2019
Closed
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baude baude Awaiting requested review from baude

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@giuseppe @openshift-ci-robot @rh-atomic-bot @rhatdan @baude @cevich @openshift-merge-robot