Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint to restart Podman machine to really accept new certificates #24908

Conversation

jmozmoz
Copy link
Contributor

@jmozmoz jmozmoz commented Dec 28, 2024

Does this PR introduce a user-facing change?

None

Add a small hint to the tutorial about Install Certificate Authority that a restart of the Podman machine might be necessary to really accept the newly added certificates.

This fixes #24593.

@rhatdan
Copy link
Member

rhatdan commented Jan 6, 2025

/approve
Thanks @jmozmoz
You need to sign commits

git commit -a --amend -s
git push --force

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmozmoz, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
Signed-off-by: jmozmoz <joachim.herb@gmx.de>
@jmozmoz
Copy link
Contributor Author

jmozmoz commented Jan 6, 2025

/approve Thanks @jmozmoz You need to sign commits

git commit -a --amend -s
git push --force

@rhatdan: I already did this. But now I have done it again and used my github login name. Before, it was my "real" one. Is it okay now?

@jmozmoz jmozmoz force-pushed the machine_restart_after_certificate_installation branch from 0211f8b to 7a51916 Compare January 6, 2025 23:13
@mheon
Copy link
Member

mheon commented Jan 7, 2025

LGTM. @baude PTAL

@rhatdan
Copy link
Member

rhatdan commented Jan 7, 2025

/lgtm
Thanks @jmozmoz

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ddc19ff into containers:main Jan 7, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation about certificate installation incomplete: Need to restart podman machine
3 participants