Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to ShmSize in Pods with Quadlet #24899

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add support to ShmSize in Pods with Quadlet #24899

merged 1 commit into from
Jan 6, 2025

Conversation

Odilhao
Copy link
Contributor

@Odilhao Odilhao commented Dec 23, 2024

This closes #22915

Add support for ShmSize in Pods created with Quadlet.
Add e2e tests.
Add new Docs entry.

Does this PR introduce a user-facing change?

Users are now able to define the ShmSize value on Pod Units for containers created with quadlets.

@Odilhao Odilhao force-pushed the pod-shm-size-issue branch 4 times, most recently from a083f93 to 9c9f20a Compare December 23, 2024 22:02
@rhatdan
Copy link
Member

rhatdan commented Dec 24, 2024

/approve
LGTM
Thanks @Odilhao

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2024
ygalblum
ygalblum requested changes Dec 24, 2024
View reviewed changes
pkg/systemd/quadlet/quadlet.go Outdated Show resolved Hide resolved
@Odilhao Odilhao force-pushed the pod-shm-size-issue branch 2 times, most recently from 2cd9f72 to d33ed1f Compare December 26, 2024 03:30
ygalblum
ygalblum approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygalblum
Copy link
Contributor

I've restarted the failed test (doesn't seem related to this change)

@Odilhao
Copy link
Contributor Author

Odilhao commented Dec 30, 2024

LGTM

Want me to squash the commits?

@Odilhao
Add support to ShmSize in Pods with Quadlet
d1a3f96 
This closes containers#22915

Signed-off-by: Odilon Sousa <osousa@redhat.com>
@Odilhao
Copy link
Contributor Author

Odilhao commented Dec 30, 2024

Did one last commit, squashing the 3 commits.

@ygalblum
Copy link
Contributor

Did one last commit, squashing the 3 commits.

Thanks, I missed the fact that there were multiple ones. I see there was an internal error in the build system. I'll try to re-run it

@ygalblum
Copy link
Contributor

ygalblum commented Jan 6, 2025

@rhatdan @containers/podman-maintainers PTAL

Luap99
Luap99 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, Odilhao, rhatdan, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,rhatdan,ygalblum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7786378 into containers:main Jan 6, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 approved these changes

@ygalblum ygalblum ygalblum approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podman v5 Quadlet .pod support for "ShmSize=" parameter
4 participants
@Odilhao @rhatdan @ygalblum @Luap99