Run codespell on source #23367
Run codespell on source #23367
Conversation
test/e2e/pod_start_test.go
Outdated
| @@ -98,7 +98,7 @@ var _ = Describe("Podman pod start", func() { | |||
| session = podmanTest.Podman([]string{"pod", "start", podid1, podid2}) | |||
| session.WaitWithDefaultTimeout() | |||
| // Different network backends emit different messages; check only the common part | |||
| Expect(session).To(ExitWithError(125, "ddress already in use")) | |||
| Expect(session).To(ExitWithError(125, "address already in use")) | |||
There was a problem hiding this comment.
This one is intentional. Some errors use capital-A Address, some lower-case.
|
I'm tempted to leave the title as-is :-) |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
Fixed title as well. Need recursive codespell. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -309,7 +309,7 @@ test/version/version: version/version.go | |||
|
|
|||
| .PHONY: codespell | |||
| codespell: | |||
| codespell -S bin,vendor,.git,go.sum,.cirrus.yml,"*.fish,RELEASE_NOTES.md,*.xz,*.gz,*.ps1,*.tar,swagger.yaml,*.tgz,bin2img,*ico,*.png,*.1,*.5,copyimg,*.orig,apidoc.go" -L secon,passt,bu,hastable,te,clos,ans,pullrequest,uint,iff,od,seeked,splitted,marge,erro,hist,ether,specif -w | |||
| codespell -S bin,vendor,.git,go.sum,.cirrus.yml,"*.fish,RELEASE_NOTES.md,*.xz,*.gz,*.ps1,*.tar,swagger.yaml,*.tgz,bin2img,*ico,*.png,*.1,*.5,copyimg,*.orig,apidoc.go" -L ddress,secon,passt,bu,hastable,te,clos,ans,pullrequest,uint,iff,od,seeked,splitted,marge,erro,hist,ether,specif -w | |||
There was a problem hiding this comment.
Is there a way to add magic comments, like for linters, immediately adjacent to the offending word? ISTM that we want to allow exactly one instance of ddress, but maybe not new ones?
There was a problem hiding this comment.
No idea, although I don't think this is a common spelling mistake.
|
@edsantiago mergeme? |
|
/lgtm Restarted yet another podman-machine flake |
2015137
into
containers:main
Does this PR introduce a user-facing change?