-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logformatter: tweaks to pass html tidy #23360
logformatter: tweaks to pass html tidy #23360
Conversation
Plus, I think my ampersand-quot change earlier this month caused problems for firefox. We no longer need it (pull-option does not need the funky double-quoted curly-brace string), so, remove it. Signed-off-by: Ed Santiago <santiago@redhat.com>
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
LGTM |
Yeah, much better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Windows tests are failing despite retry. Looks like the |
No, it will pass eventually I think. It is just super flaky for some reason, not sure what changed. I assume this is tracked in you machine flake issue? Properly need to get this assigned to someone. |
I'm not tracking it, because there are WAY Too many podman-machine flakes, with slightly different symptoms, and it would take me hours to look at each one every day and assign it to "sleep hang" or "something else". So, no, I'm just ignoring them all in my flake catalog. |
Yes, I've updated #22551 with the last week-or-so of podman machine flakes. |
e317863
into
containers:main
Plus, I think my ampersand-quot change earlier this month
caused problems for firefox. We no longer need it (pull-option
does not need the funky double-quoted curly-brace string),
so, remove it.
Signed-off-by: Ed Santiago santiago@redhat.com