-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libkrun Mac task #23290
Add libkrun Mac task #23290
Conversation
4c03ab7
to
9cd83de
Compare
|
Testing note: Confirmed (expected) libkrun tests all fail when run on Mac's w/o libkrun. |
Opened #23296 |
@edsantiago and/or @baude if you want to give the first two commits an initial look over, this PR is code-complete once containers/automation#208 is merged and deployed to the pool management VM (after I'm back from PTO). |
FYI- I'll be off on PTO next week, so won't be enabling libkrun testing in Podman until I return. There are changes needed on the Mac's used for CI and I don't want to risk breaking something while I'm away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative LGTM with two concerns
The libkrun mac tests are also passing. I will merge containers/automation#208 shortly, then after a day or so this PR can have final review and testing performed (i.e. after the pool has updated). |
This PR can move forward on/after 2024-08-01T18:50:12+00:00, by then all the Macs in the pool will be running the new setup. |
8be721b
to
48eef6d
Compare
Force-push:
|
Signed-off-by: Chris Evich <cevich@redhat.com>
Issue 23296 Signed-off-by: Chris Evich <cevich@redhat.com>
48eef6d
to
457c645
Compare
This is ready for final review and (assuming CI passes) merging. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0bc0739
into
containers:main
Depends on: containers/automation#208 + deployment into worker pool.
Does this PR introduce a user-facing change?