Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic if a runtime was configured without paths #22640

Merged
merged 1 commit into from
May 13, 2024
Merged

Don't panic if a runtime was configured without paths #22640

merged 1 commit into from
May 13, 2024

Conversation

the-sun-will-rise-tomorrow
Copy link
Contributor

#22561

Does this PR introduce a user-facing change?

Fix panic when a runtime was configured without executable paths.

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label May 8, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5
Copy link
Member

lsm5 commented May 8, 2024

@WxNzEMof is your fork rebased on the latest main branch? Any case, ignore the epel-next-8 branch failures and the epel-next-9 is a FIPS issue that's being worked on separately.

Also please sign-off on your commit: https://github.com/containers/podman/pull/22640/checks?check_run_id=24729084861

@the-sun-will-rise-tomorrow
Don't panic if a runtime was configured without paths
7bfac4f 
Signed-off-by: WxNzEMof <143541718+WxNzEMof@users.noreply.github.com>
@the-sun-will-rise-tomorrow
Copy link
Contributor Author

Thanks, I have done this.

@mheon mheon added the No New Tests Allow PR to proceed without adding regression tests label May 8, 2024
@mheon
Copy link
Member

mheon commented May 8, 2024

/approve
LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, WxNzEMof

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
lsm5
lsm5 reviewed May 9, 2024
View reviewed changes
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 PTAL

@rhatdan
Copy link
Member

rhatdan commented May 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 443e377 into containers:main May 13, 2024
90 of 91 checks passed
@Luap99 Luap99 mentioned this pull request May 15, 2024
Closed
@edsantiago edsantiago mentioned this pull request Jul 22, 2024
Open
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 12, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lsm5 lsm5 lsm5 left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-sun-will-rise-tomorrow @lsm5 @mheon @rhatdan