Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and remove parameter settings in .golangci.yml #22629

Merged
merged 1 commit into from
May 7, 2024

Conversation

qianxi0410
Copy link
Contributor

Does this PR introduce a user-facing change?

None
  1. Replace the deadline parameter with the timeout parameter. see Rename deadline option to timeout and mark deadline as deprecated golangci/golangci-lint#793
  2. Remove useless parameters. https://golangci-lint.run/usage/linters/#errcheck & https://golangci-lint.run/usage/linters/#nolintlint

Signed-off-by: qianxi0410 <894871277@qq.com>
@qianxi0410 qianxi0410 changed the title gpdate and remove parameter settings in .golangci.yml update and remove parameter settings in .golangci.yml May 7, 2024
@mheon
Copy link
Member

mheon commented May 7, 2024

/approve
LGTM on my end
@Luap99 @cevich PTAL

Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, qianxi0410

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@cevich
Copy link
Member

cevich commented May 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@cevich
Copy link
Member

cevich commented May 7, 2024

(I restarted the machine-linux test, failure is unrelated to this PR)

@openshift-merge-bot openshift-merge-bot bot merged commit a634840 into containers:main May 7, 2024
89 of 90 checks passed
@qianxi0410 qianxi0410 deleted the ci branch May 8, 2024 02:56
@Luap99
Copy link
Member

Luap99 commented May 8, 2024

@qianxi0410 Thanks for the links in the PR description, for the future please add them to the actual commit message as well.

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 7, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants