Quadlet/Container: Add GroupAdd option

[xkr47]

Does this PR introduce a user-facing change?

Quadlet/Container: Add GroupAdd option

I have not written anything in Go before and did not manage to run the test I added locally.

[ygalblum]

Thanks for the PR

The test case you've added is not executed. You need to add an entry here: https://github.com/containers/podman/blob/main/test/e2e/quadlet_test.go#L786 to pick it up

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[xkr47]

Thanks for the PR

Thanks for being quick to review it proactively help me out!

The test case you've added is not executed. You need to add an entry here: https://github.com/containers/podman/blob/main/test/e2e/quadlet_test.go#L786 to pick it up

Tried to do that 🤞

[ygalblum]

Please squash all commits into one (it will also solve the "Build Each Commit" test

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xkr47, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ygalblum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

LGTM

[xkr47]

Ah, right, forgot to mention, I ~copypasted the description from the podman-run manpage, so it might not be a perfect match stylewise. Let me know if you want me to work on that.

[ygalblum]

To avoid duplication, the Quadlet man page usually does not provide the entire documentation of the field. Instead, it states the equivalent argument.
So, I guess here you can keep the first sentence, maybe also the note about keep-groups and conclude with "Equivalent to the Podman --group-add option"

[ygalblum]

Ah, right, forgot to mention, I ~copypasted the description from the podman-run manpage, so it might not be a perfect match stylewise. Let me know if you want me to work on that.

Thanks for pointing this out. I've added a comment about it

[xkr47]

Pushed fixes and a typo in the mapping table. Let me know if you want me to squash the commits after the review.

Btw I guess it is customary not to do validation of the arguments at this stage but let podman report any errors, should there be any..?

[ygalblum]

Pushed fixes and a typo in the mapping table. Let me know if you want me to squash the commits after the review.

Btw I guess it is customary not to do validation of the arguments at this stage but let podman report any errors, should there be any..?

Yes, Quadlet leaves the argument validation to Podman. Please squash all commits

[ygalblum]

/lgtm