Fix mount propagation. #1305
Fix mount propagation. #1305
Conversation
|
@rhatdan I take it this fixes our mount issues? LGTM regardless |
|
@mheon Partially. I have a PR for runc to really fix it. But we will see how that goes. |
|
bot, retest this please |
|
☔ The latest upstream changes (presumably 4a95ef4) made this pull request unmergeable. Please resolve the merge conflicts. |
c723fb4 to
8209fde
Compare
|
bot, retest this please |
|
could the default be |
|
I was just going with the default that we went with in Docker. We could always move this to a setting in libpod if it was considered important. But for now I think SLAVE keeps us the safest. |
test/e2e/run_test.go
Outdated
| Expect(match).Should(BeFalse()) | ||
| }) | ||
|
|
||
| It("podman run findmnt nothing shared", func() { |
Default mount propagation inside of containes should be private Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
LGTM |
|
LGTM |
|
📌 Commit 8072f34 has been approved by |
|
LGTM |
|
LGTM |
|
☀️ Test successful - status-papr |
All volumes mount points should default to "private".
Root Propagation needs to default to "shared", since users
could mount a volume in as shared.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com