Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor podman image command output #12455

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Nov 30, 2021

Leverage new report.Formatter allowing better compatibility from
podman command output.

Follow on PR's will cover containers, etc.

See #10974
Depends on containers/common#831

Signed-off-by: Jhon Honce jhonce@redhat.com

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2021
@jwhonce jwhonce requested a review from ashley-cui November 30, 2021 18:15
@jwhonce jwhonce self-assigned this Nov 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@rhatdan
Copy link
Member

rhatdan commented Nov 30, 2021

LGTM
@vrothberg PTAL

@jwhonce jwhonce marked this pull request as draft November 30, 2021 20:56
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2021
@jwhonce jwhonce marked this pull request as ready for review November 30, 2021 21:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2021
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@vrothberg
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
jwhonce added a commit to jwhonce/podman that referenced this pull request Dec 1, 2021
Leverage new report.Formatter allowing better compatibility from
podman command output.

See containers#10974
See containers#12455

Depends on containers/common#831

Signed-off-by: Jhon Honce <jhonce@redhat.com>
@jwhonce jwhonce force-pushed the issues/10974 branch 3 times, most recently from 00ed498 to af27511 Compare December 1, 2021 22:13
@TomSweeneyRedHat
Copy link
Member

All kinds of red test unhappiness @jwhonce

Leverage new report.Formatter allowing better compatibility from
podman command output.

Follow on PR's will cover containers, etc.

See containers#10974

Signed-off-by: Jhon Honce <jhonce@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2021

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4ff0ba4 into containers:main Dec 2, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants