Backport #11976 to 3.4 #12327
Merged
Backport #11976 to 3.4 #12327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to use CGO for mDNS resolution, but cross builds need CGO disabled See golang/go#12524 for details Note: Homebrew forumla will need to be updated to pick up this change Fixes containers#10737 Signed-off-by: Jhon Honce <jhonce@redhat.com>
|
@zeha: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks @zeha |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, zeha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
I don't know why this is labelled needs-rebase. I'm going to manually remove said label. |
zeha
added a commit
to zeha/podman
that referenced
this pull request
Jan 26, 2022
NATIVE_GOOS does not exist in the 3.4 branch, only on main. Fixes my backport containers#12327. Verified to fix containers#12975 (again) for me. Signed-off-by: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backport #11976 (DNS fix for macOS) to 3.4 branch.
How to verify it
Builds can use private DNS servers or mDNS available only on the macOS side to pull images from (private) registries.
Which issue(s) this PR fixes:
Fixes #10737
Special notes for your reviewer: