Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroups: use SessionBusPrivateNoAutoStartup #12107

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Oct 26, 2021

What this PR does / why we need it:

do not start up a dbus daemon if it is not already running.

How to verify it

Which issue(s) this PR fixes:

Fixes #9727

*** Please also put 'Fixes #' in the commit and PR description***

Special notes for your reviewer:

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
do not start up a dbus daemon if it is not already running.

[NO NEW TESTS NEEDED] the fix is in a dependency.

Closes: containers#9727

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021
@mheon
Copy link
Member

mheon commented Oct 26, 2021

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM
but some unhappy tests @giuseppe

@rhatdan
Copy link
Member

rhatdan commented Oct 26, 2021

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit 9fbf2a4 into containers:main Oct 27, 2021
@giuseppe giuseppe mentioned this pull request Dec 5, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman commands leak dbus-daemon processes
5 participants