Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podman play kube errors out on podman-exported yaml #3157

Closed
kofalt opened this issue May 19, 2019 · 12 comments · Fixed by #3283
Closed

Podman play kube errors out on podman-exported yaml #3157

kofalt opened this issue May 19, 2019 · 12 comments · Fixed by #3283
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@kofalt
Copy link
Contributor

kofalt commented May 19, 2019

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

This tickets represents the import woes to #2963's export woes.
I'm not yet convinced they are related.

Steps to reproduce the issue:

  1. Similar to my comment here unable to find mount source when generating kube yaml being rootless #2963 (comment), take the exported Kube yaml from the RH blog post.
    I have saved it as a gist for convenience.

  2. Observe that you are unable to import the YAML from the blog:

podman play kube blog.yml

Error: pod was given but no pod is specified: invalid argument

I was having the same problem importing my own YAML, and so reproduced it with only blog material to make the case clearer.

Output of podman version:

Version:            1.3.1-dev
RemoteAPI Version:  1
Go Version:         go1.10.4
OS/Arch:            linux/amd64

Additional environment details (AWS, VirtualBox, physical, etc.):

Physical

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 19, 2019
@baude baude self-assigned this May 19, 2019
@baude
Copy link
Member

baude commented May 19, 2019

thanks for the well written defect, i appreciate the effort

@Fodoj
Copy link
Contributor

Fodoj commented Jun 7, 2019

Any update on this? Seems like play kube is unusable in 1.3.1

@mheon
Copy link
Member

mheon commented Jun 7, 2019

I think this is fixed upstream, and will be in 1.4.0 (which I'm releasing as we speak - #3280

@Fodoj
Copy link
Contributor

Fodoj commented Jun 8, 2019

@mheon I tried with current master branch and it still doesn't work. New error is Error: error running container create option: log driver must be set: invalid argument

@haircommander
Copy link
Collaborator

hey @Fodoj can you PTAL at #3283 and let me know if it fixes your play kube woes?

@mheon
Copy link
Member

mheon commented Jun 8, 2019 via email

@Fodoj
Copy link
Contributor

Fodoj commented Jun 8, 2019

Re testing: I can only agree whole play kube feature needs to be better tested. I have different bugs in 1.3.1, 1.3.2 and now 1.4.0 versions, feels like there are no tests for this feature at all!

@haircommander don't have time to test it right now, I rolled back to 1.3.0, otherwise development of my app was blocked.

@kofalt
Copy link
Contributor Author

kofalt commented Jun 17, 2019

Could this be reopened?

I'm afraid that on pod 1.4.0 from apt, using the same instructions above, I get a different error:

$ podman play kube blog.yml
Trying to pull quay.io/baude/demodb:latest...Getting image source signatures
Copying blob a3ed95caeb02 done

# ...

Copying blob a068a53bcb17 done
Writing manifest to image destination
Storing signatures
Error: error running container create option: log driver must be set: invalid argument

This is reminiscent of #3283, and the patch author actually mentions play kube:

note: I considered fixing it on the play kube side, but instead opted for this

Let me know if anyone has trouble reproducing.

$ podman version
Version:            1.4.0
RemoteAPI Version:  1
Go Version:         go1.10.4
OS/Arch:            linux/amd64

@haircommander
Copy link
Collaborator

Hey @kofalt this was fixed with podman 1.14.1 can you try that out?

@mheon
Copy link
Member

mheon commented Jun 18, 2019

I think you mixed up your versioning there - it's 1.4.1 😄

@mheon
Copy link
Member

mheon commented Jun 18, 2019

(We also have improved upstream testing for play kube so failures like this should be much less frequent from here on)

@kofalt
Copy link
Contributor Author

kofalt commented Jun 18, 2019

Sounds good. I can confirm 1.4.1 solves the issue!

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants