Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$GLOBAL_OPTS runlabel is not implemented #12436

Closed
edsantiago opened this issue Nov 29, 2021 · 4 comments · Fixed by #12529
Closed

$GLOBAL_OPTS runlabel is not implemented #12436

edsantiago opened this issue Nov 29, 2021 · 4 comments · Fixed by #12529
Assignees
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

$GLOBAL_OPTS was added in #2905. Only one month later it got broken, and the test was "temporarily" disabled in #3328:

Completely disable global options test
We need to cut a release. We can investigate further next week.

Obviously nobody has used this feature since June 2019. It might not be important enough to reimplement. If so, it should be removed from the code and documentation.

Possible reproducer:

$ printf "FROM alpine\nLABEL RUN echo \$GLOBAL_OPTS\n" | bin/podman --log-level error --tmpdir /var/tmp build -t foo:bar -
...
$ bin/podman --log-level error container runlabel RUN foo:bar
[expect: something with `--log-level`. Actual output: nil]

(I may have the number of backslashes wrong in the line above. It's impossible to know, because the code doesn't trigger no matter how many backslashes I add).

@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2021

GLOBAL_OPTS only works with podman runlabel not with podman build?

@vrothberg
Copy link
Member

I'll take a look. As always, thanks @edsantiago for the great reports.

@edsantiago
Copy link
Member Author

If you find the problem, there's already a test you can un-skip:

It("podman container runlabel global options", func() {
fmt.Printf("FIXME: for lint. Remove when you fix this test: %s", GlobalDockerfile)
Skip("FIXME: $GLOBAL_OPTS does not work at all, #12436")

@vrothberg
Copy link
Member

Thanks!

@vrothberg vrothberg self-assigned this Dec 7, 2021
@vrothberg vrothberg added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Dec 7, 2021
vrothberg added a commit to vrothberg/libpod that referenced this issue Dec 8, 2021
GLOBAL_OPTS haven't been supported for at least two major versions of
Podman.  The runlabel code is extremely fragile and I think it should
be rewritten before adding new features.

Fixes: containers#12436
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants