podman image rm --force also untags other images (3.2.0 regression)

[Vogtinator]

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

When running podman image rm -f foo, not just foo is deleted, but all references to that image.

This is a behaviour change and I couldn't find any explicit mention of that in the changelog.

Steps to reproduce the issue:

Have multiple tags for the same image:

localhost:~ # podman pull registry.opensuse.org/opensuse/busybox
Trying to pull registry.opensuse.org/opensuse/busybox:latest...
Getting image source signatures
Copying blob 739c8f977454 done  
Copying config 984a5392cf done  
Writing manifest to image destination
Storing signatures
984a5392cf0c5319b77dc0202c50951652f894f27e90fec35b5444127bfbd71d
localhost:~ # podman tag registry.opensuse.org/opensuse/busybox alsobusybox
localhost:~ # podman image ls
REPOSITORY                              TAG     IMAGE ID      CREATED                 SIZE
registry.opensuse.org/opensuse/busybox  latest  984a5392cf0c  Less than a second ago  12 MB
localhost/alsobusybox                   latest  984a5392cf0c  Less than a second ago  12 MB

Then delete any one of them:

localhost:~ # podman image rm -f registry.opensuse.org/opensuse/busybox
Untagged: registry.opensuse.org/opensuse/busybox:latest
Untagged: localhost/alsobusybox:latest
Deleted: 984a5392cf0c5319b77dc0202c50951652f894f27e90fec35b5444127bfbd71d

This does not happen with podman 3.1.2:

localhost:~ # podman version
Version:      3.1.2
API Version:  3.1.2
Go Version:   go1.13.15
Built:        Thu Apr 22 20:00:00 2021
OS/Arch:      linux/amd64
localhost:~ # podman image rm -f registry.opensuse.org/opensuse/busybox
Untagged: registry.opensuse.org/opensuse/busybox:latest

Output of podman version:

Version:      3.2.0
API Version:  3.2.0
Go Version:   go1.13.15
Built:        Mon Jun  7 20:00:00 2021
OS/Arch:      linux/amd64

and

Version:      3.2.1
API Version:  3.2.1
Go Version:   go1.13.15
Built:        Sun Jun 13 20:00:00 2021
OS/Arch:      linux/amd64

Output of podman info --debug:

podman info --debug

host:
  arch: amd64
  buildahVersion: 1.21.0
  cgroupControllers:
  - memory
  - pids
  cgroupManager: systemd
  cgroupVersion: v2
  conmon:
    package: conmon-2.0.27-1.3.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.27, commit: unknown'
  cpus: 4
  distribution:
    distribution: '"opensuse-tumbleweed"'
    version: "20210606"
  eventLogger: journald
  hostname: localhost.localdomain
  idMappings:
    gidmap: null
    uidmap: null
  kernel: 5.12.9-1-default
  linkmode: dynamic
  memFree: 2376101888
  memTotal: 8330924032
  ociRuntime:
    name: runc
    package: runc-1.0.0~rc95-1.2.x86_64
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc95
      commit: 12644e614e25b05da6fd08a38ffa0cfe1903fdec
      spec: 1.0.2-dev
      go: go1.13.15
      libseccomp: 2.5.1
  os: linux
  remoteSocket:
    path: /run/podman/podman.sock
  security:
    apparmorEnabled: true
    capabilities: CAP_AUDIT_WRITE,CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER,CAP_FSETID,CAP_KILL,CAP_MKNOD,CAP_NET_BIND_SERVICE,CAP_NET_RAW,CAP_SETFCAP,CAP_SETGID,CAP_SETPCAP,CAP_SETUID,CAP_SYS_CHROOT
    rootless: false
    seccompEnabled: true
    seccompProfilePath: /usr/share/containers/seccomp.json
    selinuxEnabled: false
  serviceIsRemote: false
  slirp4netns:
    executable: ""
    package: ""
    version: ""
  swapFree: 0
  swapTotal: 0
  uptime: 4h 37m 1.64s (Approximately 0.17 days)
registries:
  search:
  - registry.opensuse.org
  - docker.io
store:
  configFile: /etc/containers/storage.conf
  containerStore:
    number: 0
    paused: 0
    running: 0
    stopped: 0
  graphDriverName: btrfs
  graphOptions: {}
  graphRoot: /var/lib/containers/storage
  graphStatus:
    Build Version: 'Btrfs v5.12.1 '
    Library Version: "102"
  imageStore:
    number: 0
  runRoot: /var/run/containers/storage
  volumePath: /var/lib/containers/storage/volumes
version:
  APIVersion: 3.2.0
  Built: 1623110400
  BuiltTime: Mon Jun  7 20:00:00 2021
  GitCommit: ""
  GoVersion: go1.13.15
  OsArch: linux/amd64
  Version: 3.2.0

Package info (e.g. output of rpm -q podman or apt list podman):

podman-3.2.0-1.1.x86_64

and

podman-3.2.1-3.1.x86_64

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/master/troubleshooting.md)

Yes.

Additional environment details (AWS, VirtualBox, physical, etc.):

VM. Originally found by openQA: https://openqa.opensuse.org/tests/1788281#step/registry/137

[mheon]

@vrothberg PTAL

[vrothberg]

Thanks for reaching out, @Vogtinator!

I can confirm, it's a regression. We did a major rewrite of the image handling.

[vrothberg]

Opened containers/common#630

[vrothberg]

This has been fixed in master. Backported to v3.2.2 (soon to be released) via #10763.