-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement compatMode raw JSON output and fix tls_verify init on pull() #495
base: main
Are you sure you want to change the base?
Conversation
445f654
to
706411d
Compare
/retest |
@D3vil0p3r: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: D3vil0p3r <vozaanthony@gmail.com>
@rhatdan I hope you are well. When you have free time, could you please give a quick check? "Test on Fedora" is failing because it cannot find the Alpine image, so, looking on its logs, I think it is an error not related to the PR. |
Thanks @D3vil0p3r |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: D3vil0p3r, rhatdan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes LGTM |
Fix #492
Added
compatMode
param topull()
function. Default asTrue
in order to give a detailed progress JSON output by default like:while
compatMode=False
still keeps the one-fieldstream
JSON output:This approach differs from the already present
progress_bar=True
because does not show the "fancy" progress bar but a raw detailed progressing JSON output, useful for devs want to manipulate pull output.Furthermore, the PR fixes
tls_verify
initialization inpull()
because, according to its description, its Default should beTrue
, but it was actually asNone
.