-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "decode" parameter in pull() #484
base: main
Are you sure you want to change the base?
Conversation
@jwhonce PTAL |
I also integrated a test. It can be run on
@jwhonce sorry for the ping, could you please review also this PR? Thanks |
@D3vil0p3r Could you squash your commits. |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: D3vil0p3r, rhatdan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Implement `decode (bool)` parameter in `pull()`. Decode the JSON data from the server into dicts. Only applies with `stream=True`. Signed-off-by: Antonio <vozaanthony@gmail.com>
Thank you very much. Commit squashed. |
Implement
decode (bool)
parameter inpull()
. Decode the JSON data from the server into dicts. Only applies withstream=True
.If
decode
is not implemented, the output will be something like:By implementing
decode
the pull output will be:It partial covers #456