Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to eslint v9 #1623

Merged
merged 1 commit into from
Aug 29, 2024
Merged

chore: upgrade to eslint v9 #1623

merged 1 commit into from
Aug 29, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 28, 2024

What does this PR do?

update to the new flat config format of eslint

need to disable 2 rules from sonarjs lint plug-in as it's not yet fully compliant

some code is not 100% compliant with the rules so I've commented the rules, but then after it should be fixed rule by rule

search for // disabled as code in this project is not yet compliant: in the source code

Also the cache is enabled for lint:check / lint:fix rules

Screenshot / video of UI

What issues does this PR fix or reference?

fixes #1607

How to test this PR?

PR check should be ✅

@benoitf benoitf requested review from jeffmaury and a team as code owners August 28, 2024 19:30
also bump all dependencies

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit 6a154af into containers:main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to eslint v9.9.1
3 participants