Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused file #1609

Merged
merged 1 commit into from
Aug 28, 2024
Merged

chore: remove unused file #1609

merged 1 commit into from
Aug 28, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 28, 2024

What does this PR do?

dependabot is scanning this file and report issues but this file should not be there as there is one in the root folder

Screenshot / video of UI

What issues does this PR fix or reference?

How to test this PR?

@benoitf benoitf requested review from jeffmaury and a team as code owners August 28, 2024 08:45
@jeffmaury jeffmaury enabled auto-merge (squash) August 28, 2024 08:52
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you forgot DCO

yarn.lock is at the root folder

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
Copy link
Collaborator Author

benoitf commented Aug 28, 2024

yes I always forgot that on this repo it's not adding the signed off for me automatically !

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffmaury jeffmaury merged commit 0fa0862 into containers:main Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants