Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge: add vlan support #1161

Merged
merged 1 commit into from
Jan 15, 2025
Merged

bridge: add vlan support #1161

merged 1 commit into from
Jan 15, 2025

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jan 10, 2025

Implement a new vlan option that turn the bridge vlan_filtering mode on and then assign the host side veth to the given vlan id.

With that a users should be able to have multiple networks with the same bridge but different vlan ids (we need to change network create logic fo this).

Fixes #1028

Implement a new vlan option that turn the bridge vlan_filtering mode on
and then assign the host side veth to the given vlan id.

With that a users should be able to have multiple networks with the same
bridge but different vlan ids (we need to change network create logic fo
this).

Fixes containers#1028

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member

baude commented Jan 14, 2025

lgtm

@mheon
Copy link
Member

mheon commented Jan 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a8e952b into containers:main Jan 15, 2025
26 checks passed
@Luap99 Luap99 deleted the vlan branch January 19, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VLAN support in bridge network driver
3 participants