This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Add dns search domain to cni result #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local host name lookup is slow and can time out because the search domain is not added to resolv.conf. We have to add the configured domain name to the dns search domain cni result so podman can read it back and add it to resolv.conf, similar to how it is done for the nameservers. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
|
Partially fixes #55 |
Luap99
pushed a commit
to Luap99/libpod
that referenced
this pull request
Feb 24, 2021
This fixes slow local host name lookups. see containers/dnsname#57 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
|
Also see containers/podman#9501 |
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local host name lookup is slow and can time out because
the search domain is not added to resolv.conf.
We have to add the configured domain name to the dns search domain
cni result so podman can read it back and add it to resolv.conf,
similar to how it is done for the nameservers.