crun delete: call systemd's reset-failed

[kolyshkin]

According to the OCI runtime spec (https://github.com/opencontainers/runtime-spec/blob/main/runtime.md#delete), runtime's delete is supposed to remove all the container's artefacts.

In case systemd cgroup driver is used, and the systemd unit has failed (e.g. oom-killed), systemd won't remove the unit (that is, unless the "CollectMode: inactive-or-failed" property is set).

Leaving a leftover failed unit is a violation of runtime spec; in addition, a leftover unit result in inability to start a container with the same systemd unit name (such operation will fail with "unit already exists" error).

Call reset-failed from systemd's cgroup manager destroy_cgroup call, so the failed unit will be removed (by systemd) after "crun delete".

This change is similar to the one in runc (see opencontainers/runc#3888). A (slightly modified) test case from runc added by the above change was used to check that the bug is fixed.

For bigger picture, see:

• runc systemd cgroup driver logic is wrong opencontainers/runc#3780 (issue A);
• OOM detection is racy when using systemd cgroup driver cri-o/cri-o#7035.

To test manually, systemd >= 244 is needed. Create a container config that runs sleep 10 and has the following systemd annotations:

org.systemd.property.RuntimeMaxUSec: "uint64 2000000"
org.systemd.property.TimeoutStopUSec: "uint64 1000000"

Start a container using --systemd-cgroup option.

The container will be killed by systemd in 2 seconds, thus its systemd unit status will be "failed". Once it has failed, the systemctl status $UNIT_NAME should have exit code of 3 (meaning "unit is not active").

Now, run crun delete $CTID and repeat systemctl status $UNIT_NAME. It should result in exit code of 4 (meaning "no such unit").

[kolyshkin]

Oh, and here's how to use runc test to test crun:

1. Get runc repo:

$ git clone https://github.com/opencontainers/runc
$ cd runc

2. Apply the following diff (required because runc recognizes that *Sec property argument needs to be uint64, see opencontainers/runc@1cd71df):

[kir@kir-rhat runc]$ git diff
diff --git a/tests/integration/delete.bats b/tests/integration/delete.bats
index adcca2c4..4363b976 100644
--- a/tests/integration/delete.bats
+++ b/tests/integration/delete.bats
@@ -175,8 +175,8 @@ EOF
        set_cgroups_path
        # shellcheck disable=SC2016
        update_config '   .annotations += {
-                               "org.systemd.property.RuntimeMaxSec": "2",
-                               "org.systemd.property.TimeoutStopSec": "1"
+                               "org.systemd.property.RuntimeMaxUSec": "uint64 2000000",
+                               "org.systemd.property.TimeoutStopUSec": "uint64 1000000"
                           }
                        | .process.args |= ["/bin/sleep", "10"]'
 

2. Run the test:

$ sudo -s
# RUNC=/path/to/crun RUNC_USE_SYSTEMD=yes bats tests/integration/delete.bats

You will see an unrelated failure from a different test (which I'm going to fix). The main thing is, "runc delete removes failed systemd unit" should fail before and pass after the fix.

[giuseppe]

LGTM