Allow runc to access setattr on the fifo_file #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was initially done in f6c7f41 but the access on unconfined_service_t is missing as well. See containers/podman#1980 (comment) Closes containers/podman#1980
|
ping @rhatdan |
rhatdan
reviewed
Dec 15, 2018
| @@ -515,8 +515,9 @@ optional_policy(` | |||
| optional_policy(` | |||
| unconfined_domain(container_runtime_t) | |||
| unconfined_run_to(container_runtime_t, container_runtime_exec_t) | |||
| role_transition unconfined_r container_runtime_exec_t system_r; | |||
There was a problem hiding this comment.
Why are you deleting this line?
There was a problem hiding this comment.
I'm not removing this line, I'm adding unconfined_service_t into that line.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was initially done in f6c7f41 but
the access on unconfined_service_t is missing as well.
See containers/podman#1980 (comment)
Closes containers/podman#1980