Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: complete containers#556 to-do list part 4 #707

Merged
merged 1 commit into from
Aug 3, 2021
Merged

style: complete containers#556 to-do list part 4 #707

merged 1 commit into from
Aug 3, 2021

Conversation

unknowndevQwQ
Copy link
Contributor

Finish the last unfinished part
close #693

Signed-off-by: unknowndevQwQ@github unknowndevQwQ@protonmail.com

Finish the last unfinished part
@unknowndevQwQ
Copy link
Contributor Author

/assign @rhatdan

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 3, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, saschagrunert, unknowndevQwQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 3, 2021
@openshift-ci openshift-ci bot merged commit de7e08f into containers:main Aug 3, 2021
@unknowndevQwQ unknowndevQwQ deleted the patch-1 branch August 5, 2021 01:38
@unknowndevQwQ unknowndevQwQ mentioned this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A question about name value pairs
4 participants