Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete containers#556 to-do list #694

Merged
merged 4 commits into from
Aug 1, 2021
Merged

complete containers#556 to-do list #694

merged 4 commits into from
Aug 1, 2021

Conversation

unknowndevQwQ
Copy link
Contributor

Some details: #556 (comment)

Signed-off-by: unknowndev233@github unknowndevQwQ@protonmail.com

delete the line 134 extra spaces added by commit 26511c0
add a line break between the description and the option
delete space before the option to make it clear that it is an option
line feed indentation are two spaces
@unknowndevQwQ
Copy link
Contributor Author

/assign @rhatdan

@rhatdan
Copy link
Member

rhatdan commented Jul 26, 2021

LGTM
@saschagrunert @vrothberg @giuseppe @containers/podman-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Jul 26, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, unknowndev233

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

I think we're back to the reminder that the contributing guidelines require the author to reveal their name. I think that's the third time I remind of that. Did something change or is there an exception I am not aware of?

@unknowndevQwQ
Copy link
Contributor Author

I think we're back to the reminder that the contributing guidelines require the author to reveal their name. I think that's the third time I remind of that. Did something change or is there an exception I am not aware of?

I am forced to remain anonymous because I didn't want to be sent to prison for national security reasons by the government. My first PR may have explained the situation. However, the translation engine may cause deviations in what I want to say

@vrothberg
Copy link
Member

I am very sorry to read that, @unknowndev233!

Unfortunately that does not change our contributing guidelines. Please let's resolve this issue before opening more pull requests. Note that we don't do this to reveal private information but for legal reasons; every author has rights.

@rhatdan @TomSweeneyRedHat shall I reach out to legal? Maybe we can get make an exception or maybe there's a special rule that would allow @unknowndev233 to continue contributing.

@TomSweeneyRedHat
Copy link
Member

I think the best thing to do is to thoroughly review his PR's like this one, and then if it's satisfactory, have an identified person from the community grab the git diff and create a separate PR. My $.02, but throwing an email past the legal eagles might not be a bad idea @vrothberg

@unknowndevQwQ
Copy link
Contributor Author

Unfortunately that does not change our contributing guidelines. Please let's resolve this issue before opening more pull requests. Note that we don't do this to reveal private information but for legal reasons; every author has rights.

I know, but I don't want to disclose my real name directly

@rhatdan
Copy link
Member

rhatdan commented Jul 28, 2021

@unknowndev233 We do not want to force you to reveal your name. We are just making sure we handle this as legally as possible.

@unknowndevQwQ
Copy link
Contributor Author

@unknowndev233 We do not want to force you to reveal your name. We are just making sure we handle this as legally as possible.

I agree with @TomSweeneyRedHat's solution

@rhatdan
Copy link
Member

rhatdan commented Aug 1, 2021

Legal has determined that this content change is not copy-writable, so that we can merge without a real signature.

@rhatdan
Copy link
Member

rhatdan commented Aug 1, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 1, 2021
@rhatdan
Copy link
Member

rhatdan commented Aug 1, 2021

Thanks @unknowndev233

@rhatdan
Copy link
Member

rhatdan commented Aug 1, 2021

/hold cancel

@openshift-ci openshift-ci bot merged commit 3d65aeb into containers:main Aug 1, 2021
@unknowndevQwQ unknowndevQwQ deleted the patch-1 branch August 2, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants