Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing on name value pairs to be consistent #620

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jun 10, 2021

Replaces: #556

Signed-off-by: unknowndev233@github unknowndevQwQ@protonmail.com
Signed-off-by: Daniel J Walsh dwalsh@redhat.com

Replaces:  containers#556

Signed-off-by: unknowndev233@github unknowndevQwQ@protonmail.com
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan rhatdan added the lgtm label Jun 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit db86400 into containers:main Jun 14, 2021
@unknowndevQwQ
Copy link
Contributor

@rhatdan Is there a plan to adjust the indentation of line feeds?

@rhatdan
Copy link
Member Author

rhatdan commented Jun 30, 2021

Not that I have looked at.

@unknowndevQwQ
Copy link
Contributor

Not that I have looked at.

Do I create a new pr to display them?

@rhatdan
Copy link
Member Author

rhatdan commented Jul 25, 2021

If you want the change, that would be best.

@unknowndevQwQ
Copy link
Contributor

If you want the change, that would be best.

I'm ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants