made necessary changes to handle OS/Arch while importing an image #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
vrothberg
reviewed
Jun 8, 2021
| @@ -23,6 +23,9 @@ type ImportOptions struct { | |||
| CommitMessage string | |||
| // Tag the imported image with this value. | |||
| Tag string | |||
| // Pref Platform for the image | |||
| OS string | |||
| Arch string | |||
There was a problem hiding this comment.
Please add comments to both fields. This way the comments will show up in doc generators and IDEs.
`// Overwrite OS/Arch of imported image.
Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
1f00040 to
ed87b61
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
This was referenced Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cdoern cbdoer23@g.holycross.edu
Making necessary changes in order to reference a platform as described in this issue on podman. This PR modifies the ImportOptions struct to handle OS/Arch and added two lines so that the config reads in these new parameters. Will open up a new PR on podman to handle parsing of OS/Arch here.
This is stemming from implementation of the platform parameter in the docker-compatabile API of podman. As seen in image_routes.go the docker engine handles platform with both fromSrc and fromImage. In order to mirror this, certain structs on this end must be modified.