Add default for log-tag #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@containers/podman-maintainers PTAL |
pkg/config/config.go
Outdated
| @@ -137,6 +137,10 @@ type ContainersConfig struct { | |||
| // Negative values indicate that the log file won't be truncated. | |||
| LogSizeMax int64 `toml:"log_size_max,omitempty"` | |||
|
|
|||
| // Specifies default format tag for container log messages. Helpful for specific | |||
| // container log, messages. Containers logs default to truncated container ID. | |||
There was a problem hiding this comment.
If you change the above, change here too.
There was a problem hiding this comment.
Something must have gone wrong while copy-pasting. The sentence above starts in the middle.
|
@containers/podman-maintainers PTAL |
vrothberg
reviewed
Jun 9, 2021
docs/containers.conf.5.md
Outdated
| **log_tag**="" | ||
|
|
||
| Default format tag for container log messages. This is useful for creating a specific tag for container log messages. Container log messages default to using the truncated container ID as a tag. | ||
| container log, messages. Containers logs default to truncated container ID. |
There was a problem hiding this comment.
Suggested change
| container log, messages. Containers logs default to truncated container ID. |
ce0f069 to
2ca5af7
Compare
Needed for containers/podman#10204 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for containers/podman#10204
Signed-off-by: Daniel J Walsh dwalsh@redhat.com