[0.14] Ensure that rootless cgroupsv1 will select cgroupfs #235
Conversation
The current logic is that, if Podman was built with the systemd build flag, we will always select systemd cgroups by default. Then, if we detect no systemd dbus session, we will swap to cgroupfs. Problem: there are cases where a systemd dbus session is available, but systemd cgroups don't work - most notably, rootless mode on cgroups v1 systems. Special-case this so that we will not try to force systemd mode and break rootless containers. Fixes containers/podman#6982 Cherry-picked commit a61c5e2. Signed-off-by: Matthew Heon <matthew.heon@pm.me> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Now, the PR includes commits to bump the version. Once merged we can cut the release and get it into Podman's 2.0 branch. |
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
a425a79 to
0c43914
Compare
|
LGTM |
|
@mheon PTAL |
|
LGTM, thanks @vrothberg |
|
I think this is still manual merge land, so I'm pressing the button. @rhatdan can you spin a fresh release of 0.14 so we can vendor into Podman 2.0? |
|
@mheon Released. |
|
Excellent, thanks. |
…cvlan core,macvlan: add `gateway` from spec as default route to `macvlan` interface
The current logic is that, if Podman was built with the systemd
build flag, we will always select systemd cgroups by default.
Then, if we detect no systemd dbus session, we will swap to
cgroupfs. Problem: there are cases where a systemd dbus session
is available, but systemd cgroups don't work - most notably,
rootless mode on cgroups v1 systems. Special-case this so that we
will not try to force systemd mode and break rootless containers.
Fixes containers/podman#6982
Cherry-picked commit a61c5e2.
Signed-off-by: Matthew Heon matthew.heon@pm.me
Signed-off-by: Valentin Rothberg rothberg@redhat.com