Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.58] Don't abort listing tags when we encounter a digest #2069

Merged
merged 4 commits into from
Jun 29, 2024

Conversation

TomSweeneyRedHat
Copy link
Member

Setting c/common v0.58.4 up to handle containers/skopeo#2346, that happens
in the wild.

Per containers/skopeo#2346, that happens
in the wild.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

We were not able to find or create Copr project packit/containers-common-2069 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=containers-common-2069 chroots=['epel-9-x86_64', 'centos-stream-10-x86_64']): Response is not in JSON format, there is probably a bug in the API code.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@TomSweeneyRedHat
Copy link
Member Author

@cevich or maybe @lsm5 any thoughts on the COPR issue?

@lsm5
Copy link
Member

lsm5 commented Jun 28, 2024

/packit build

Luap99 and others added 3 commits June 28, 2024 13:34
We see issues in CI where we fail to pull from k8s.gcr.io. As k8s uses a
new registry URL migrate to that[1] and hope it fixes the issues.

[1] https://kubernetes.io/blog/2023/02/06/k8s-gcr-io-freeze-announcement/

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
As the title says

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
As the title says.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/addon-v0.58 branch from 755425c to e218e61 Compare June 28, 2024 17:35
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 28, 2024
@rhatdan rhatdan merged commit 12cd869 into containers:v0.58 Jun 29, 2024
10 checks passed
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/addon-v0.58 branch August 9, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants