Document more buildah build --secret options #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retitle Document more buildah build --secret options |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
flouthoc
approved these changes
Oct 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhatdan
reviewed
Oct 17, 2024
|
|
||
| To later use the secret, use the --mount flag in a `RUN` instruction within a `Containerfile`: | ||
|
|
||
| `RUN --mount=type=secret,id=mysecret cat /run/secrets/mysecret` | ||
|
|
||
| Note: Changing the contents of secret files will not trigger a rebuild of layers that use said secrets. | ||
| The location of the secret in the container can be overridden using the |
759059a to
af1fe4e
Compare
Describe the "env" and "type" options in the buildah-build(1) man page. When parsing the "--secret=" flag for the CLI, instead of ignoring an option that we don't recognize, return an error. Even though the set of meaningful "id" values for secrets is passed in via the command line, don't directly use it to construct a file path. Change the default mode for SSH agent sockets that we create from 0o620 to 0o600. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
/kind other
What this PR does / why we need it:
How to verify it
Updated test to verify that we complain about unrecognized
--secret=options!Which issue(s) this PR fixes:
Resolves #5282, or at least points people in the right direction.
Special notes for your reviewer:
Does this PR introduce a user-facing change?