Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] Packit: Enable sidetags for bodhi updates #5730

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 11, 2024

Packit now has sidetag support for adding multiple builds into a single bodhi update.

Since we release c/ccommon, skopeo, buildah and podman often almoost simultaneously, we should release them to Fedora in a single bodhi update using sidetags so all builds can be tested together.

What type of PR is this?

/kind other

What this PR does / why we need it:

Makes Fedora package updates easier

How to verify it

We can only verify this after the next release which ships this config.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Packit now has sidetag support for adding multiple builds into a single
bodhi update.

Since we release c/ccommon, skopeo, buildah and podman often
almoost simultaneously, we should release them to Fedora in a single
bodhi update using sidetags so all builds can be tested together.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
ELN is kind of a midway between Fedora and RHEL, so it's best to mention
ELN jobs separately. This will also allow reusing fedora targets using
YAML anchors for TMT tests.

This commit also mentions fedora-40 targets separately for copr_build
jobs so that once fedora-41 is released, fedora-40 jobs continue to
trigger.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5 lsm5 changed the title [skip-ci] Packit: enable Fedora sidetag [skip-ci] Packit: Enable sidetags for bodhi updates Sep 11, 2024
@lsm5 lsm5 marked this pull request as ready for review September 11, 2024 13:55
@rhatdan
Copy link
Member

rhatdan commented Sep 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3f97ba1 into containers:main Sep 13, 2024
32 checks passed
@lsm5
Copy link
Member Author

lsm5 commented Sep 13, 2024

/cherrypick release-1.37

@openshift-cherrypick-robot

@lsm5: #5730 failed to apply on top of branch "release-1.37":

Applying: Packit: Enable sidetags for bodhi updates
Applying: Packit: split out ELN jobs and reuse fedora downstream targets
Using index info to reconstruct a base tree...
M	.packit.yaml
Falling back to patching base and 3-way merge...
Auto-merging .packit.yaml
CONFLICT (content): Merge conflict in .packit.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Packit: split out ELN jobs and reuse fedora downstream targets
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lsm5 lsm5 deleted the packit-sidetag branch September 17, 2024 11:53
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants